Adding sparse protocol

[rayanpiro]

Description of changes

Adding new sparse registry protocol to rust builders with minimal changes.
Properly building fetching from kellnr self hosted instance.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[marcusramberg]

Commit message should be updated to follow the commit conventions.

[winterqt]

Overall, this looks good, thank you so much! I haven't been keeping up with the progress of the sparse registry -- I had thought that it wouldn't actually change the lock file, but looks like I'm wrong there.

Could you add a small test for it? See pkgs/build-support/rust/test/import-cargo-lock. My first instinct would be to just add it to basic, but depending on how things work with lockfile generation, might be best just to add a new test.

Commit message should be updated to follow the commit conventions.

Beat me to it, thanks! +1, please do this.

[rayanpiro]

Changed commit to follow the conventions.
I'll try to review how tests are done and add a new one or modify the basic one today or tomorrow. It's not a big difference, just Cargo.lock with sparse+https:// instead of registry+https:// but I'll review it first and post if any doubt.

Overall, this looks good, thank you so much! I haven't been keeping up with the progress of the sparse registry -- I had thought that it wouldn't actually change the lock file, but looks like I'm wrong there.

That's true for crates.io, but if you want to use a self hosted alternative like kellnr isn't working with this. You have to define the registry as sparse+https://... and every dependency on Cargo.lock will be the same.

[rayanpiro]

Ok, some modifications were made looking for:

• Add support for download URL because could be or not the same than index URL.
• Modify less amount of code as possible.
• Add a basic sparse test as solicited.

Hope everything seems good enough now.

[rayanpiro]

@marcusramberg @winterqt can you please review the latest changes?

[winterqt]

I'll take a look in a few hours, thanks for re-pinging.

[marcusramberg]

lgtm