Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: use makeWrapper to link zoom.us.app into bin/ #304874

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

afh
Copy link
Contributor

@afh afh commented Apr 17, 2024

Description of changes

Add postFixup for darwin to create bin/zoom wrapper, so that mainProgram exists and is an executable script, enabling use of nix run nixpkgs#zoom-us on darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3829

@SuperSandro2000 SuperSandro2000 merged commit 14efdd4 into NixOS:master Apr 25, 2024
6 of 7 checks passed
@afh afh deleted the fix-nix-run-zoom-on-darwin branch April 25, 2024 20:40
@afh
Copy link
Contributor Author

afh commented Apr 25, 2024

Thanks for merging, @SuperSandro2000, this is going to be very helpful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants