nixos/ollama: add options to bypass sandboxing #305076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhr
reviewed
Apr 18, 2024
| @@ -87,7 +120,8 @@ in | |||
| ExecStart = "${lib.getExe ollamaPackage} serve"; | |||
| WorkingDirectory = cfg.home; | |||
| StateDirectory = [ "ollama" ]; | |||
| DynamicUser = true; | |||
| DynamicUser = cfg.sandbox; | |||
| ReadWritePaths = cfg.writablePaths; | |||
There was a problem hiding this comment.
This solves the problem with file system, but it seems like systemd also sandboxes away network. So you can't do, for example, ollama pull.
There was a problem hiding this comment.
I have tested the service's network functionality, and haven't had any problems getting it to download new models. Are you sure the problem is with the network? If it is, are you confident that it doesn't have anything to do with your local network configuration?
Could you try downloading a new model (tinydolphin is pretty small) with the default ollama service configuration (i.e. just services.ollama.enable = true;), and get back to me with the results of that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
By default, the service has some sandboxing systemd features enabled, which includes making most of the filesystem read-only. This is usually fine, but in some cases may get in the way. This allows two ways to bypass sanboxing: disabling it entirely, or giving write access to specific paths.
Resolves #304531.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.