nixos/gitlab: Add a second database connection #305764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab deprecated single database connections in 15.9. [1] From GitLab 17.0 onward it will be mandatory to define both `main` and `ci` sections in the `database.yml`. [2] This commit updates the module to address the upcoming breaking change. [1]: https://gitlab.com/gitlab-org/gitlab/-/issues/387898 [2]: https://docs.gitlab.com/16.10/ee/install/installation.html#configure-gitlab-db-settings
dasJ
approved these changes
Apr 21, 2024
tomsiewert
approved these changes
Apr 21, 2024
|
@ofborg test gitlab |
nbraud
approved these changes
May 2, 2024
nbraud
added
11.by: package-maintainer
12.approvals: 3+
and removed
12.approvals: 2
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #274518.
GitLab deprecated single database connections in 15.9.
From GitLab 17.0 onward it will be mandatory to define both
mainandcisections in thedatabase.yml, as explained in the manual.This Pull Request updates the module to address the upcoming breaking change.
Thanks to @tomsiewert for the first draft and @dasJ for sharing their
jqsnippet.Description of changes
services.postgresql.portsetting topostgresql.settings.portThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.