vscode-js-debug: init at 1.90.0

[zeorin]

Description of changes

• Add @zeorin as a maintainer
• Init vscode-js-debug at 1.90.0

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[aqrln]

Result of nixpkgs-review pr 305824 run on aarch64-linux 1

1 package built:

• vscode-js-debug

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1684

[DamienCassou]

@aqrln Are you still interested in this PR? I would like to get it merged. I could take care of the feedback if you don't want to or don't have time to.

[DamienCassou]

Thank you for your work. I'm already using it!

[DamienCassou]

awesome work, thank you.

[DamienCassou]

@zeorin: building the package fails for me as I mentioned in #305824 (comment). I don't understand why it works for you and @SuperSandro2000.

[SuperSandro2000]

I don't use the package, I just reviewed it

[DamienCassou]

I don't use the package, I just reviewed it

Ok. I mentioned you because of #305824 (review).

[zeorin]

@zeorin: building the package fails for me as I mentioned in #305824 (comment). I don't understand why it works for you and @SuperSandro2000.

I've got a fix PR up here: #320877.

The reason it was working for me is because in the process of creating my PR, I had realised buildNpmPackage's underlying npmDeps derivation, which is a fixed-output derivation. npmDeps (unless provided) is a fetchNpmDeps derivation which involves npmConfigHook, which inherits the postPatch hook, but not nativeBuildInputs, and thus will not have jq in its path. However, if it had already been realised before (such as when I was trying out lib.getExe jq), even a forced rebuild of vscode-js-debug itself wouldn't trigger a rebuild of its npmDeps unless the npmDepsHash had actually changed.

I was wary of using lib.getExe jq since jq is a build time dependency and not a runtime dependency, meaning that nativeBuildInputs is traditionally the correct place to add it. Using lib.getExe jq is, from a cross-compilation perspective, equivalent to adding a dependency to buildInputs, which is more appropriate for runtime dependencies.

When I created this initial PR, I was not aware of buildPackages, the use of which allows me to be sure that the jq we use is appropriate for a build time dependency.

[DamienCassou]

Thank you very much for the fix and explanation.