Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

redlib.tests: fix eval #305925

Merged
merged 1 commit into from Apr 26, 2024
Merged

redlib.tests: fix eval #305925

merged 1 commit into from Apr 26, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Apr 22, 2024

Without the change the eval fails as:

$ nix build --no-link -f. redlib.tests
error: attribute 'redlib' missing
   at pkgs/by-name/re/redlib/package.nix:50:26:
       49|   passthru.tests = {
       50|     inherit (nixosTests) redlib;
         |                          ^
       51|   };
   Did you mean redis?

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Without the change the eval fails as:

    $ nix build --no-link -f. redlib.tests
    error: attribute 'redlib' missing
       at pkgs/by-name/re/redlib/package.nix:50:26:
           49|   passthru.tests = {
           50|     inherit (nixosTests) redlib;
             |                          ^
           51|   };
       Did you mean redis?
@pyrox0
Copy link
Member

pyrox0 commented Apr 24, 2024

Checked, this works.

@amaxine amaxine merged commit 11aa9c6 into NixOS:master Apr 26, 2024
27 checks passed
@trofi trofi deleted the redlib.tests-fix-eval branch April 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants