buildComposerProject/Repository: drop empty phases #306226
Conversation
Tested by building pixelfed and librenms and verifying that the buildPhase is still run
|
I may be wrong, but these phases were left there for the |
| @@ -29,38 +29,9 @@ let | |||
| patches = previousAttrs.patches or [ ]; | |||
| strictDeps = previousAttrs.strictDeps or true; | |||
|
|
|||
| # Should we keep these empty phases? | |||
There was a problem hiding this comment.
IIRC, the point is to prevent running ./configure, make & co., while still being able to overrideAttrs like in mkDerivation-based packages (e.g. without having to also override dontConfigure back to false). It should probably be documented.
There was a problem hiding this comment.
@SuperSandro2000 Do you plan to do something in here?
There was a problem hiding this comment.
Do the packages even contain files which would be run? It is probably surprising if they are not run here and it masks the default mkDerivation behavior.
There was a problem hiding this comment.
What do you mean? something like ./configure? Then it's no.
Tested by building pixelfed and librenms and verifying that the buildPhase is still run
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.