Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdlib: 1.8.27 -> 1.8.28 #306255

Merged
merged 1 commit into from
May 22, 2024
Merged

tdlib: 1.8.27 -> 1.8.28 #306255

merged 1 commit into from
May 22, 2024

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Apr 23, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Vonfry
Copy link
Member Author

Vonfry commented Apr 23, 2024

Result of nixpkgs-review pr 306255 run on x86_64-linux 1

1 package marked as broken and skipped:
  • pidginPackages.tdlib-purple
8 packages built:
  • emacsPackages.telega
  • python311Packages.python-telegram
  • python311Packages.python-telegram.dist
  • python312Packages.python-telegram
  • python312Packages.python-telegram.dist
  • tdlib
  • tg
  • tg.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3877

@getchoo
Copy link
Member

getchoo commented May 5, 2024

Result of nixpkgs-review pr 306255 run on aarch64-linux 1

1 package marked as broken and skipped:
  • pidginPackages.tdlib-purple
9 packages built:
  • emacsPackages.telega
  • python311Packages.python-telegram
  • python311Packages.python-telegram.dist
  • python312Packages.python-telegram
  • python312Packages.python-telegram.dist
  • tdlib
  • tests.pkg-config.defaultPkgConfigPackages.tdjson
  • tg
  • tg.dist

@@ -11,8 +11,8 @@ stdenv.mkDerivation {
# The tdlib authors do not set tags for minor versions, but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I understood.

You basically keep track from master but do not use the <version>-unstable-<date> format because the upstream sets a version in CMakeLists?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You basically need to find the commit with the version bump and that is the version.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker. LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1658

@drupol drupol merged commit 3f316d2 into NixOS:master May 22, 2024
34 checks passed
@Vonfry Vonfry deleted the tdlib-1.8.28 branch May 22, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants