Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cue: fix version format #306317

Merged
merged 1 commit into from Apr 30, 2024
Merged

Conversation

selfuryon
Copy link
Contributor

@selfuryon selfuryon commented Apr 23, 2024

Description of changes

Pass the version to cue in format vX.X.X instead of X.X.X. It is needed for modules because in the current version I got this:

$ cue mod init glacial-tech.example/frostyconfig@v0
cannot round-trip module file: language version "0.8.1" in - is not well formed

This happens because cue expects semver version with v letter.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.


Maintainer pings

cc @aaronjheng

@selfuryon
Copy link
Contributor Author

I have no idea why, but I can't add @aaronjheng as a reviewer to this PR...

@ofborg ofborg bot requested a review from aaronjheng April 29, 2024 11:38
@Aleksanaa Aleksanaa merged commit 815e6eb into NixOS:master Apr 30, 2024
26 checks passed
@selfuryon selfuryon deleted the chore/cue-version-fix branch May 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants