Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt: 0.33.10 -> 0.33.12 #306333

Closed
wants to merge 1 commit into from
Closed

tilt: 0.33.10 -> 0.33.12 #306333

wants to merge 1 commit into from

Conversation

vindard
Copy link

@vindard vindard commented Apr 23, 2024

Description of changes

Updates Tilt from version 0.33.10 to 0.33.12.

This PR also introduces an alternative to fetchYarnDeps to build the yarn offline cache. This is required because of the issue at #254369 and the fix introduced was inspired by the approach in the comment at #277697 (comment) by @Eisfunke

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vindard vindard changed the title tilt: 0.33.11 -> 0.33.12 tilt: 0.33.10 -> 0.33.12 Apr 23, 2024
@vindard
Copy link
Author

vindard commented Apr 25, 2024

Not sure what the process is to have this reviewed. Maybe @drupol?

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I'm not an expert in the Node world... so I won't be giving a good review here.

However, on the CI I notice hash mismatches are on some platforms, how come?

@szlend
Copy link
Member

szlend commented Apr 27, 2024

I get a hash mismatch when building yarn-deps on aarch64-darwin. I don't think this is reproducible between systems unfortunately.

@vindard
Copy link
Author

vindard commented Apr 27, 2024

I get a hash mismatch when building yarn-deps on aarch64-darwin. I don't think this is reproducible between systems unfortunately.

I just got my hands on a Mac system today. Will test and see if I can figure out how to fix.

Edit: I was able to reproduce the exact incorrect Darwin hash from CI on aarch64-darwin as well. I tried a few simple things, but I think I'm out of my depth with this one. Closing until someone comes along with a better solution for this.

@vindard vindard closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants