Revert "workflows: add concurrency group to check-by-name workflow" #306430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75600cd.
|
Hmm maybe it does run after all queued checks complete. Still looking for an example of it being canceled with no other pending checks. |
|
Huh weird, yeah let's revert for now, thanks for double-checking this! |
|
Ahh:
I guess we should use |
Ah that makes sense! |
|
Btw I restarted all the cancelled builds manually (were only a couple), I think it should all be resolved now |
infinisil
added a commit
to NixOS/nixfmt
that referenced
this pull request
Apr 24, 2024
Turns out `github.ref` doesn't point to the pull request's ref when using `pull_request_target`: NixOS/nixpkgs#306430
infinisil
added a commit
to NixOS/nixfmt
that referenced
this pull request
Apr 25, 2024
Turns out `github.ref` doesn't point to the pull request's ref when using `pull_request_target`: NixOS/nixpkgs#306430
infinisil
added a commit
to NixOS/nixfmt
that referenced
this pull request
Apr 25, 2024
Turns out `github.ref` doesn't point to the pull request's ref when using `pull_request_target`: NixOS/nixpkgs#306430
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 75600cd.
Description of changes
@infinisil I don't think it's working as expected.
Add a 馃憤 reaction to pull requests you find important.