Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movim: 0.23.0.20240328 → 0.24 #306454

Merged
merged 1 commit into from
Apr 24, 2024
Merged

movim: 0.23.0.20240328 → 0.24 #306454

merged 1 commit into from
Apr 24, 2024

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Apr 24, 2024

Note: this does not fix the bcrypt issue with Nixpkgs’s PHP being ahead of what Movim’s maintainers are using currently

movim/movim#1311

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

Note: this does *not* fix the `bcrypt` issue with Nixpkgs’s PHP being
ahead of what Movim’s maintainers are using currently

movim/movim#1311
@Lassulus
Copy link
Member

Result of nixpkgs-review pr 306454 run on x86_64-linux 1

1 package built:
  • movim

@Lassulus Lassulus merged commit 334650c into NixOS:master Apr 24, 2024
30 of 31 checks passed
@toastal toastal deleted the movim-0.24 branch April 24, 2024 18:07
@toastal toastal restored the movim-0.24 branch April 28, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants