polychromatic: 0.8.0 -> 0.9.1

[nadir-ishiguro]

Description of changes

Changelogs:

• https://github.com/polychromatic/polychromatic/releases/tag/v0.9.0
• https://github.com/polychromatic/polychromatic/releases/tag/v0.8.4
• https://github.com/polychromatic/polychromatic/releases/tag/v0.8.3
• https://github.com/polychromatic/polychromatic/releases/tag/v0.8.2
• https://github.com/polychromatic/polychromatic/releases/tag/v0.8.1

The qt6 port of polychromatic just got released and I noticed that the package hasn't been updated in a while

I don't really know what I'm doing, but I did my best to get it running and it does. The tray icon appears as expected and the controller/main app runs fine.

I added qt6.qtbase as I got the following build error without it:

Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
wrapQtAppsHook qtHostPathHook: qtPluginPrefix is unset. hint: add qt6.qtbase to buildInputs
/nix/store/7cn0p1zbg7cgklcldk08ld6hvrwrq4av-wrap-qt6-apps-hook/nix-support/setup-hook: line 27: qtPluginPrefix: parameter null or not set

So I did what the hint said and things build fine.

I also replaced libappindicator-gtk3 with libayatana-appindicator as the former seems to be deprecated and this seems to be the recommended replacement.

Would be grateful if somebody would look over the changes and improve things I missed.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nadir-ishiguro]

Result of nixpkgs-review pr 306509 run on x86_64-linux 1

1 package built:

• polychromatic

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3874

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3995

[SebTM]

Result of nixpkgs-review pr 306509 run on x86_64-linux 1

1 package built:

• polychromatic

[SebTM]

LGTM 👍🏻 Built and ran it locally but don't have a device to test.

FIY (found while clicking around):

qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""

We could consider doing something like here and this to use wayland and fallback to x if not available.

sh: line 1: killall: command not found
You might need to add psmisc as runtimeDependency and/or patch the path here

Cant find "/usr/share/openrazer/razer.conf.example"
Lastly the daemon is searching in a XDG-folder not available on nix for the default config

But all except the first not blocking a merge from my pov ✌🏻

[nadir-ishiguro]

I've added qt6.qtwayland to buildInputs and psmisc to propagatedBuildInputs.

It runs fine on my 2016 blade, but it did so from the first commit.

Do you think adding qt6.qtwayland this way is enough?

[SebTM]

Do you think adding qt6.qtwayland this way is enough?

Yes message is gone for me and killall works as well 🙏🏻

[nadir-ishiguro]

Result of nixpkgs-review pr 306509 run on x86_64-linux 1

1 package built:

• polychromatic

[nadir-ishiguro]

Great. Thank you for your help!

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1699