Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcl-lsp: init at 0.8.3 #306538

Closed
wants to merge 1 commit into from
Closed

kcl-lsp: init at 0.8.3 #306538

wants to merge 1 commit into from

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 24, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: peefy <xpf6677@163.com>
@Peefy
Copy link
Contributor Author

Peefy commented Apr 26, 2024

Hello community. May I ask if anyone can help review it? All CI tests are passed. Thank you all!

1 similar comment
@Peefy
Copy link
Contributor Author

Peefy commented May 6, 2024

Hello community. May I ask if anyone can help review it? All CI tests are passed. Thank you all!

@Peefy Peefy closed this Jun 5, 2024
@kukacz
Copy link

kukacz commented Jun 13, 2024

Hi, was this one closed for lack of reviewers? I find it important to have KCL Language Server package in addition to the existing kcl-cli. Having to install language server some other way is strange when the basic CLI package is in place already.

@Peefy
Copy link
Contributor Author

Peefy commented Jun 13, 2024

Yes. Nobody reviews it. 😔 But I will open another PR to build kcl language server using Cargo in Nix.

@kukacz
Copy link

kukacz commented Jun 13, 2024

Yes. Nobody reviews it. 😔 But I will open another PR to build kcl language server using Cargo in Nix.

Great, thanks for the effort! Kindly leave a note in this thread when the new PR is opened. I'll watch this one and add my voice for the reviewers request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants