clapper: 0.5.2 -> 0.6.0; clean up and move to finalAttrs

[kashw2]

Description of changes

closes #306475

https://github.com/Rafostar/clapper/releases/tag/0.6.0

removed the explicit postInstall as the icons and other images are now output to $out/share without it
removed variable and overwritable repo name by explicitly declaring clapper as the repo in src
moved some nativeBuildInputs into buildInputs
added vala, cmake and libmicrodns as nativeBuildInputs and buildInputs respectively
updated libsoup to libsoup_3
moved the derivation to finalAttrs

in the future it may be worth it to split this derivation into two for the two different outputs (the clappergtk lib and clapper the application)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[kashw2]

Result of nixpkgs-review pr 306548 run on x86_64-linux 1

1 package built:

• clapper

[Rafostar]

Hi, thanks for updating this! Just two things if I may:

1. Commit title: 0.5.2 -> 0.5.0 - is this a downgrade? 🙃
2. Latest version of Clapper no longer uses GJS, please consider removing it from dependencies and app description (OpenGL rendering part can also be removed/updated actually).

[kashw2]

Hi, thanks for updating this! Just two things if I may:

1. Commit title: `0.5.2 -> 0.5.0` - is this a downgrade? 🙃

2. Latest version of Clapper no longer uses `GJS`, please consider removing it from dependencies and app description (OpenGL rendering part can also be removed/updated actually).

Hi, thanks for the catch on these two.

I've amended the commit title to be correct after the version typo and have removed gjs from the derivation's attribute set, buildInputs and the long description.

[Aleksanaa]

Others look okay, will test

[JohnRTitor]

Result of nixpkgs-review pr 306548 run on x86_64-linux 1

1 package built:

• clapper

[Aleksanaa]

Works ...okay? But I have no idea why it plays media in another window

Does it work on GNOME?

[Rafostar]

Works ...okay? But I have no idea why it plays media in another window

Please try to run it with --gst-debug=clappergtkvideo:5

Should print lines like:

0:00:03.260855584 37688      0x194b4b0 DEBUG        clappergtkvideo clapper-gtk-video.c:1005:_video_sink_changed_cb:<ClapperGtkVideo@0x19ce040> Video sink changed to: <glsinkbin0>
0:00:03.260909462 37688      0x194b4b0 DEBUG        clappergtkvideo clapper-gtk-video.c:980:_get_widget_from_video_sink: Video sink provides a widget

[Aleksanaa]

0:00:00.266347674 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now inactive
0:00:00.511464359 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:1005:_video_sink_changed_cb:<ClapperGtkVideo@0x2347660> Video sink changed to: (NULL)
0:00:00.511491901 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:1038:_video_sink_changed_cb:<ClapperGtkVideo@0x2347660> No widget from video sink, using placeholder
0:00:00.511501669 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:1044:_video_sink_changed_cb:<ClapperGtkVideo@0x2347660> Set new video widget

(clapper:679006): Gtk-WARNING **: 16:09:07.808: Allocating size to ClapperAppWindow 0x251b420 without calling gtk_widget_measure(). How does the code know the size to allocate?
0:00:00.539143857 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now active

(clapper:679006): Gtk-WARNING **: 16:09:07.832: Allocating size to ClapperAppWindow 0x251b420 without calling gtk_widget_measure(). How does the code know the size to allocate?
0:00:02.214443466 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now inactive
0:00:02.270493884 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now active
0:00:02.416223097 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now inactive
0:00:12.148997125 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now active
0:00:12.279236648 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:907:_set_inhibit_session:<ClapperGtkVideo@0x2347660> Trying to inhibit session...

(clapper:679006): Gtk-WARNING **: 16:09:19.571: Calling org.freedesktop.portal.Inhibit.Inhibit failed: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Inhibit” on object at path /org/freedesktop/portal/desktop
0:00:12.279621873 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:937:_set_inhibit_session:<ClapperGtkVideo@0x2347660> Session inhibited
0:00:12.279972634 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now inactive
0:00:13.183247397 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now active
0:00:15.820866414 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:582:_window_is_active_cb:<ClapperGtkVideo@0x2347660> Window is now inactive
0:00:18.724117810 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:558:_fade_overlay_delay_cb:<ClapperGtkVideo@0x2347660> Can fade overlays: yes

[Aleksanaa]

Seems to be a problem with hyprland, we have nothing to do with it

[Rafostar]

@Aleksanaa

0:00:00.511464359 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:1005:_video_sink_changed_cb:<ClapperGtkVideo@0x2347660> Video sink changed to: (NULL)
0:00:00.511491901 679006      0x25956b0 DEBUG        clappergtkvideo clapper-gtk-video.c:1038:_video_sink_changed_cb:<ClapperGtkVideo@0x2347660> No widget from video sink, using placeholder

Seems to be a problem with hyprland, we have nothing to do with it

From the log it seems to be a packaging problem, actually.

Normally at startup Clapper requests GStreamer to load and create a videosink (in case of GStreamer 1.24 - glsinkbin together with clappersink), but here it seems to be not found, NULL is returned and then Clapper tires to recover by using any other video display it can find and ends up with one that cannot be placed within UI - thus another window is created to display video.

[Aleksanaa]

I'll look into it

[Aleksanaa]

@JohnRTitor Could you reproduce the bug?

[JohnRTitor]

Yes, indeed, also using Hyprland.

[Aleksanaa]

Path problem, very probably