Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delfin: 0.4.2 -> 0.4.4 #306614

Merged
merged 2 commits into from
Apr 26, 2024
Merged

delfin: 0.4.2 -> 0.4.4 #306614

merged 2 commits into from
Apr 26, 2024

Conversation

coolavery
Copy link
Member

Description of changes

Changelog:

  • Fix video playback opening a separate window with MPV 0.38.0
  • Translation updates – thanks to Codeberg users gallegonovato, Medzik, ThetaDev, and Tuba2

Also added myself to the list of maintainers, I'm happy to update this package as part of the upstream release process. Thanks @uninsane and @t4ccer for packaging this!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome, Avery!

points reviewed:

  • built for x86_64.
  • tested basic functionality.
  • new maintainer entry is consistent with the norms described in maintainers/README.md; githubId matches the API

@Aleksanaa Aleksanaa merged commit 21124b7 into NixOS:master Apr 26, 2024
32 checks passed
@coolavery coolavery deleted the delfin-0.4.4 branch April 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants