Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapce: 0.3.1 -> 0.4.0 #306918

Merged
merged 2 commits into from Apr 26, 2024
Merged

lapce: 0.3.1 -> 0.4.0 #306918

merged 2 commits into from Apr 26, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 26, 2024

Description of changes

Changelog: https://github.com/lapce/lapce/releases/tag/v0.4.0

cc @Eliot00

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 306918 run on aarch64-linux 1

1 package built:
  • lapce

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 306918 run on x86_64-linux 1

1 package built:
  • lapce

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 306918 run on aarch64-darwin 1

1 package built:
  • lapce

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 306918 run on x86_64-darwin 1

1 package failed to build:
  • lapce

@GaetanLepage
Copy link
Contributor Author

Failed on x86_64-darwin with:

   ...
   Compiling lapce v0.4.0 (/private/tmp/nix-build-lapce-0.4.0.drv-1/source)
error: linking with `/nix/store/cx6fs6pkpn3iacbygpy2r0kj45qvay7n-clang-wrapper-16.0.6/bin/cc` failed: exit status: 1
  |
  = note: env -u IPHONEOS_DEPLOYMENT_TARGET -u TVOS_DEPLOYMENT_TARGET LC_ALL="C" PATH="/nix/store/3xpcx4gyjh4qgm78f75ybw6w6ijn8qfx-rustc-1.77.1/lib/rustlib/x86_64-apple-darwin/bin:/>
  = note: Undefined symbols for architecture x86_64:
            "_NSPasteboardTypeFileURL", referenced from:
                objc::rc::autorelease::autoreleasepool::h503171c6c210163d in libcopypasta-d11428c364fbae8a.rlib(copypasta-d11428c364fbae8a.copypasta.91d208312f6a166b-cgu.1.rcgu.o)
          ld: symbol(s) not found for architecture x86_64
          clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
          

error: could not compile `lapce` (bin "lapce") due to 1 previous error

@GaetanLepage
Copy link
Contributor Author

Failed on x86_64-darwin with:

Nevermind, this is also happening on master.

Copy link
Contributor

@Eliot00 Eliot00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the darwin part, I don't know if just a newer sdk is needed, but I don't actually know anything about it. Others lgtm

@pbsds pbsds merged commit 637f958 into NixOS:master Apr 26, 2024
28 checks passed
@GaetanLepage GaetanLepage deleted the lapce branch April 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants