-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to Added temp-throttle package #307074
base: master
Are you sure you want to change the base?
Conversation
Fix function arguments. Co-authored-by: xzfc <5121426+xzfc@users.noreply.github.com>
I'm seeing "rebuild darwin". This package will Only run on systems with Linux kernel. |
|
I don't know how to resolve this error. It builds without issue on my machine, and appears to be consistent with the syntax of other packages.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I've added some suggestions. Also, you should split your changes into three commits: one for adding yourself to the maintainers list, one for adding the package and one for adding the module. See the CONTRIBUTING.md on how to write appropriate commit messages.
I'm not really sure what you mean "split". Do you want me to squash the commits? |
Yes, sorry |
Description of changes
I am the author of temp-throttle. This is a request to add package. Service module also coming- I wanted to test pull request of package first.
It is a Linux shell script for throttling system CPU frequency based on a desired maximum temperature. Prevent system overheating due to bad thermal/fan drivers, or passive cooling, or broken fans.
Things done
It is written entirely in Bash and GNU utils. Compatible with all architectures of Linux. Linux only.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.