Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Added temp-throttle package #307074

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

Sepero
Copy link

@Sepero Sepero commented Apr 26, 2024

Description of changes

I am the author of temp-throttle. This is a request to add package. Service module also coming- I wanted to test pull request of package first.

It is a Linux shell script for throttling system CPU frequency based on a desired maximum temperature. Prevent system overheating due to bad thermal/fan drivers, or passive cooling, or broken fans.

Things done

It is written entirely in Bash and GNU utils. Compatible with all architectures of Linux. Linux only.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

pkgs/by-name/te/package.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/package.nix Outdated Show resolved Hide resolved
Sepero and others added 2 commits April 27, 2024 12:56
Fix function arguments.

Co-authored-by: xzfc <5121426+xzfc@users.noreply.github.com>
@Sepero
Copy link
Author

Sepero commented Apr 27, 2024

I'm seeing "rebuild darwin". This package will Only run on systems with Linux kernel.

nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/temp-throttle/package.nix Show resolved Hide resolved
pkgs/by-name/te/temp-throttle/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/temp-throttle/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/temp-throttle/package.nix Outdated Show resolved Hide resolved
@xzfc
Copy link
Contributor

xzfc commented Apr 27, 2024

I'm seeing "rebuild darwin". This package will Only run on systems with Linux kernel.

rebuild-darwing: 0 means none of Darwin packages were updated.

@Sepero
Copy link
Author

Sepero commented May 2, 2024

I don't know how to resolve this error. It builds without issue on my machine, and appears to be consistent with the syntax of other packages.

error: undefined variable 'Sepero'

maintainers = with lib.maintainers; [ Sepero ];

Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I've added some suggestions. Also, you should split your changes into three commits: one for adding yourself to the maintainers list, one for adding the package and one for adding the module. See the CONTRIBUTING.md on how to write appropriate commit messages.

nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/temp-throttle/package.nix Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/temp-throttle.nix Outdated Show resolved Hide resolved
@Sepero
Copy link
Author

Sepero commented May 19, 2024

Also, you should split your changes into three commits: one for adding yourself to the maintainers list, one for adding the package and one for adding the module.

I'm not really sure what you mean "split". Do you want me to squash the commits?

@misuzu
Copy link
Contributor

misuzu commented May 19, 2024

Do you want me to squash the commits?

Yes, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants