Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmuxp: add pyyaml as build dep, to fix build error #307233

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 27, 2024

Description of changes

Fixes #307046

  • adds pyyaml as build dependency, so nix does not complain :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@JohnRTitor
Copy link
Contributor Author

Pinging maintainers: @peterhoeg @otavio

@peterhoeg
Copy link
Member

Can I trouble you to remove me as a maintainer? I haven't used tmuxp in ages.

@JohnRTitor
Copy link
Contributor Author

Sure :) still need a review though

@Artturin Artturin merged commit 2617024 into NixOS:master Apr 27, 2024
22 of 24 checks passed
@JohnRTitor JohnRTitor deleted the tmuxp branch April 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: tmuxp
3 participants