Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: remove msfjarvis #307283

Merged
merged 1 commit into from Apr 27, 2024

Conversation

msfjarvis
Copy link
Contributor

Description of changes

It's been a great few years of being a small part of the community but I think I'm done now. This orphans a few packages but I'm sure someone else who gives a shit can take over, same as I did.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the maintainers lines back which got fully removed to better indicate that the package is unmaintained.

@SuperSandro2000 SuperSandro2000 merged commit 33812a1 into NixOS:master Apr 27, 2024
21 checks passed
@msfjarvis msfjarvis deleted the hs/remove-maintainer branch April 27, 2024 21:18
@hraban
Copy link
Contributor

hraban commented Apr 28, 2024

Thank you for all your contributions to the nixpkgs Android ecosystem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants