Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinymist: 0.11.5 -> 0.11.6 #307522

Merged
merged 1 commit into from May 2, 2024
Merged

tinymist: 0.11.5 -> 0.11.6 #307522

merged 1 commit into from May 2, 2024

Conversation

Parsifa1
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commit and the commit message should be: tinymist: 0.11.5 -> 0.11.6 (so the CI can trigger the build)

tinymist: 0.11.5 -> 0.11.6
@Parsifa1
Copy link
Contributor Author

Parsifa1 commented May 2, 2024

Please squash your commit and the commit message should be: tinymist: 0.11.5 -> 0.11.6 (so the CI can trigger the build)

Thank you, this is my first PR, I have modified it

@drupol
Copy link
Contributor

drupol commented May 2, 2024

Thank you. Let's wait for the CI to be done before going further.

@drupol drupol merged commit e635774 into NixOS:master May 2, 2024
22 of 24 checks passed
@drupol
Copy link
Contributor

drupol commented May 2, 2024

All good! Thanks for your first contribution, welcome to the Nix family !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants