Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] alacritty: 0.12.3 β†’ 0.13.2 #307554

Closed

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 28, 2024

Description of changes

Backport alacritty 0.13.2 to 23.11 release.
Closes #307551

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a πŸ‘ reaction to pull requests you find important.

r-vdp and others added 4 commits April 29, 2024 01:50
This is technically not entirely correct (for BSDs etc), but there are other
isLinux checks in the file so let's just do this to unblock Darwin users for now.

Fixes NixOS#288468.
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2024

What was the reasoning behind the backport? Any breakages?

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 29, 2024

Didn't notice any breakage from the built binary. Although the requester did not specify any reason for Backport, this is likely to "get the latest bugfixes and features".

@Mic92
Copy link
Member

Mic92 commented Apr 29, 2024

Thanks for the work, but I feel like this defeats a bit the point of the stable NixOS release.
This backport will actually deprecated alacritty configuration options: https://github.com/alacritty/alacritty/releases/tag/v0.13.0
For those that want the latest and greatest, we have NixOS unstable.
We do backport some software that for example depends on external platforms or where it's impossible to separate security fixes from feature upgrades i.e. several electron applications.

@JohnRTitor
Copy link
Contributor Author

Closing this, then?

@JohnRTitor JohnRTitor closed this Apr 29, 2024
@JohnRTitor JohnRTitor deleted the backport-alacritty-to-23.11 branch April 30, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants