Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ironbar: 0.14.1 -> 0.15.0; added feature checks #307726

Merged
merged 1 commit into from
May 4, 2024
Merged

ironbar: 0.14.1 -> 0.15.0; added feature checks #307726

merged 1 commit into from
May 4, 2024

Conversation

kashw2
Copy link
Contributor

@kashw2 kashw2 commented Apr 29, 2024 •
edited

Description of changes

closes #307687

https://github.com/JakeStanger/ironbar/releases/tag/v0.15.0

overcame a few build issues using nix develop .#ironbar in a cloned version of ironbar, this resulted in me adding the following new inputs to fix the build issues:

  • libpulseaudio
  • luajit
  • lua51Packages.lgi

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

JakeStanger
JakeStanger suggested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@JakeStanger JakeStanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(some changes may be required - will update with deets in an hour or so)

@kashw2
Copy link
Contributor Author

kashw2 commented Apr 29, 2024

Result of nixpkgs-review pr 307726 run on x86_64-linux 1

1 package built:
  • ironbar

@JakeStanger
Copy link
Contributor

The LUA_PATH and LUA_CPATH env vars need to be set at runtime when the cairo feature is enabled (which it is by default). These need to point to the lua-lgi package. This can be done in gappsWrapperArgs.

Implementation in the repo version:

https://github.com/JakeStanger/ironbar/blob/d37547e046b50c418b6e388a249fd3e6aedfdd75/nix/default.nix#L75-L78

@ofborg ofborg bot requested review from yavko and JakeStanger April 30, 2024 02:58
yavko
yavko suggested changes Apr 30, 2024
View reviewed changes
pkgs/by-name/ir/ironbar/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from yavko April 30, 2024 06:27
yavko
yavko suggested changes Apr 30, 2024
View reviewed changes
pkgs/by-name/ir/ironbar/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from yavko April 30, 2024 07:46
@kashw2 kashw2 changed the title ironbar: 0.14.1 -> 0.15.0 ironbar: 0.14.1 -> 0.15.0; added feature checks Apr 30, 2024
donovanglover
donovanglover reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! Just some minor formatting suggestions.

pkgs/by-name/ir/ironbar/package.nix Show resolved Hide resolved
pkgs/by-name/ir/ironbar/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ir/ironbar/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested review from JakeStanger and yavko April 30, 2024 12:08
@ofborg ofborg bot requested a review from donovanglover April 30, 2024 12:08
JakeStanger
JakeStanger approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@JakeStanger JakeStanger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working, code LGTM now, cheers. Appreciate the effort in keeping this up to date :)

@ofborg ofborg bot requested review from JakeStanger and yavko May 4, 2024 15:59
@wegank wegank merged commit 9010eb2 into NixOS:master May 4, 2024
22 of 24 checks passed
@kashw2 kashw2 deleted the ironbar branch May 6, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@donovanglover donovanglover Awaiting requested review from donovanglover

@JakeStanger JakeStanger Awaiting requested review from JakeStanger

@yavko yavko Awaiting requested review from yavko

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: Ironbar 0.14.1 → 0.15.0
5 participants
@kashw2 @JakeStanger @donovanglover @wegank @yavko