nixos/nextcloud: add nextcloud-update-db.service, nextcloud-cron isn't oneshot #308291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Hubrecht
reviewed
May 1, 2024
…t oneshot This service performs operations that significantly increase the performance of Nextcloud, can take a while. These are designed however to not require maintenance mode and can be executed during normal operation[1]. Make nextcloud-cron a simple unit instead of oneshot: otherwise we risk that it'll be stopped by the startup timeout (oneshot executes ExecStart while "activating") which can be an issue for very long running tasks or if Nextcloud needs to catch up if one task was broken for a while. [1] https://docs.nextcloud.com/server/29/admin_manual/maintenance/upgrade.html#long-running-migration-steps
|
I can't fully test this, as I already have executed those occ commands some time ago and also my instance is rather small and "long running maintenance tasks" usually take less than a minute unless some recognize processing is happening. |
onny
approved these changes
May 2, 2024
SuperSandro2000
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Note: before merging this, a bit of testing would be appreciated.
This service performs operations that significantly increase the performance of Nextcloud, can take a while. These are designed however to not require maintenance mode and can be executed during normal operation[1].
Make nextcloud-cron a simple unit instead of oneshot: otherwise we risk that it'll be stopped by the startup timeout (oneshot executes ExecStart while "activating") which can be an issue for very long running tasks or if Nextcloud needs to catch up if one task was broken for a while.
[1] https://docs.nextcloud.com/server/29/admin_manual/maintenance/upgrade.html#long-running-migration-steps
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.