man-pages: restore $out/bin to fix nix-shell -p man-pages
#308363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`man 5 manpath` says that `PATH` is a default variable used to populate
manpages search path. Without the change the following session does not
work:
$ nix-shell -p man-pages
$$ man x25
No manual entry for x25
Reported in NixOS#300797 (comment)
|
LGTM (didn't test). |
Should be as easy as running:
It's slightly easier to review and fix a regression when it's local to a single package. I suggest filing fixes for other packages separately. I suspect it's a lot more than just two. Each fix will require at least light testing. |
marsam
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
man 5 manpathsays thatPATHis a default variable used to populate manpages search path. Without the change the following session does not work:Reported in #300797 (comment)
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.