Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.librosa: 0.10.1 -> 0.10.2 #308525

Closed
wants to merge 1 commit into from
Closed

python311Packages.librosa: 0.10.1 -> 0.10.2 #308525

wants to merge 1 commit into from

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented May 2, 2024 •
edited
Loading

Description of changes

Changelog: https://github.com/librosa/librosa/releases/tag/0.10.2

Fixes #306859

cc @GuillaumeDesforges

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@GaetanLepage GaetanLepage requested a review from pbsds May 2, 2024 13:15
@Aleksanaa
Copy link
Member

Is it possible to backport that PR?

@Aleksanaa
Copy link
Member

i.e.

patches = [
  (fetchpatch {
    url = "https://patch-diff.githubusercontent.com/raw/librosa/librosa/pull/1766.patch";
    hash = "<hash>";
  })
];

@GaetanLepage
Copy link
Contributor Author

Is it possible to backport that PR?

I wanted to do that but the PR contains 47 commits. Usually, we don't use fetchpatch with the PR's URL as the commits can change.
However, manually importing that many commits would be painful...
Not sure if there is a good solution.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on aarch64-darwin 1

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on x86_64-darwin 1

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on x86_64-linux 1

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on aarch64-linux 1

@GuillaumeDesforges
Copy link
Contributor

I've started working on a PR to fix nixpkgs with pre-release version.

@Aleksanaa
Copy link
Member

Usually, we don't use fetchpatch with the PR's URL as the commits can change.

That's only true for open PRs right? Once it's merged you cannot reopen it

@GuillaumeDesforges
Copy link
Contributor

See #308533

@GaetanLepage GaetanLepage changed the title python311Packages.librosa: mark as broken python311Packages.librosa: 0.10.1 -> 0.10.2 May 2, 2024
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • tts
  • tts.dist
17 packages failed to build:
  • pianotrans
  • pianotrans.dist
  • pitivi
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
  • tts
  • tts.dist
17 packages built:
  • pianotrans
  • pianotrans.dist
  • pitivi
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • piper-train
  • piper-train.dist
2 packages failed to build:
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
15 packages built:
  • pianotrans
  • pianotrans.dist
  • pitivi
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on aarch64-linux 1

The tinygrad build failure on aarch64-linux is unrelated to this update.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on aarch64-darwin 1

16 packages failed to build:
  • pianotrans
  • pianotrans.dist
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 308525 run on x86_64-darwin 1

16 packages failed to build:
  • pianotrans
  • pianotrans.dist
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.librosa
  • python311Packages.librosa.dist
  • python311Packages.piano-transcription-inference
  • python311Packages.piano-transcription-inference.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python311Packages.tinygrad
  • python311Packages.tinygrad.dist
  • python311Packages.torch-audiomentations
  • python311Packages.torch-audiomentations.dist
  • python311Packages.torchlibrosa
  • python311Packages.torchlibrosa.dist

@pbsds
Copy link
Contributor

pbsds commented May 2, 2024 •
edited
Loading

you should use https://github.com/owner/repo/compare/rev_a...rev_b.patch rather than pull IDs, but what is the problem with bumping the package?

EDIT: i didn't see the change in title

@pbsds
Copy link
Contributor

pbsds commented May 2, 2024

The nixpkgs-review darwin failures mismatches the results from ofborg, any ideas?

@GuillaumeDesforges GuillaumeDesforges mentioned this pull request May 3, 2024
Closed
13 tasks
@GaetanLepage
Copy link
Contributor Author

Obsoleted by #309391

@GaetanLepage GaetanLepage deleted the librosa branch May 6, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds Awaiting requested review from pbsds

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: pitivi, python311Packages.librosa
4 participants
@GaetanLepage @Aleksanaa @GuillaumeDesforges @pbsds