fcitx5: substitute path in all desktop files and dbus service files #308725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the desktop file uses an absolute path (see #308324) in the first place. As for the dbus service I'm admittedly not experienced enough with that to comment. |
Not sure why either. But these absolute paths are set by the upstream. https://github.com/fcitx/fcitx5/blob/5.1.9/data/org.fcitx.Fcitx5.desktop.in.in https://github.com/fcitx/fcitx5/blob/5.1.9/src/modules/dbus/org.fcitx.Fcitx5.service.in |
Vonfry
reviewed
May 5, 2024
duament
force-pushed
the
fcitx5-dbus-substitute
branch
from
776fab5
to
cf428fb
Compare
Vonfry
approved these changes
May 6, 2024
duament
changed the title
duament
force-pushed
the
fcitx5-dbus-substitute
branch
from
cf428fb
to
bab0370
Compare
Vonfry
approved these changes
Jun 1, 2024
marsam
added a commit
to marsam/home-manager
that referenced
this pull request
Jun 8, 2024
Since NixOS/nixpkgs#308725, fcitx5-with-addons expects share/dbus-1/services/ to be present. This patch updates the fcitx5 stub to reflect that.
marsam
added a commit
to marsam/home-manager
that referenced
this pull request
Jun 8, 2024
Since NixOS/nixpkgs#308725, fcitx5-with-addons expects share/dbus-1/services/ to be present. This patch updates the fcitx5 stub to reflect that.
6 tasks
sinanmohd
pushed a commit
to sinanmohd/home-manager
that referenced
this pull request
Jul 16, 2024
Since NixOS/nixpkgs#308725, fcitx5-with-addons expects share/dbus-1/services/ to be present. This patch updates the fcitx5 stub to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fcitx5 does not load addons properly if activated by dbus.
This PR substitutes the Exec path in fcitx5 dbus service file to fix it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.