Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

foomatic-db*: update and migrate to by-name and finalAttrs #309334

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

Yarny0
Copy link
Contributor

@Yarny0 Yarny0 commented May 5, 2024

Description of changes

  • update foomatic-db to newest version
  • move packages to pkgs/by-name
  • replace rec with finalAttrs where possible

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • foomatic-db
  • foomatic-db-ppds
  • foomatic-db-ppds-withNonfreeDb

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3959

@Misterio77
Copy link
Member

Result of nixpkgs-review pr 309334 run on x86_64-linux 1

3 packages built:
  • foomatic-db
  • foomatic-db-ppds
  • foomatic-db-ppds-withNonfreeDb

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4006

@SuperSandro2000 SuperSandro2000 merged commit 380c573 into NixOS:master Jun 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants