Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotconf: 1.3 -> 1.4.1 #309540

Merged
merged 1 commit into from
May 20, 2024
Merged

dotconf: 1.3 -> 1.4.1 #309540

merged 1 commit into from
May 20, 2024

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 6, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/dotconf/versions.

meta.description for dotconf is: A configuration parser library

meta.homepage for dotconf is: https://github.com/williamh/dotconf

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.4.1 with grep in /nix/store/6krjdg388q962rrwb7xh46xkfx91scmx-dotconf-1.4.1
  • found 1.4.1 in filename of file in /nix/store/6krjdg388q962rrwb7xh46xkfx91scmx-dotconf-1.4.1

Rebuild report (if merged into master) (click to expand)
477 total rebuild path(s)

477 package rebuild(s)

First fifty rebuilds by attrpath

affine
antares
archivebox
aws-azure-login
bilibili
bitwarden-desktop
bitwarden-directory-connector
blightmud-tts
blockbench
breitbandmessung
bruno
calibre
calligra
camunda-modeler
chromium
ciscoPacketTracer8
comic-mandown
cutter
cutterPlugins.rz-ghidra
dasher
deltachat-desktop
digikam
discord
discord-canary
discord-development
discord-ptb
discord-screenaudio
dotconf
drawio
drawio-headless
dropbox
dropbox-cli
electron
electron_27
electron_28
electron_29
electron_30
element-desktop
element-desktop-wayland
fast-cli
fcast-receiver
feishin
flashgbx
francis
freetube
godot_4
goldendict-ng
google-chrome
goxlr-utility
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/6krjdg388q962rrwb7xh46xkfx91scmx-dotconf-1.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A dotconf https://github.com/r-ryantm/nixpkgs/archive/5bc4581f35b7e27025ef8d6aba534d623a34a591.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/5bc4581f35b7e27025ef8d6aba534d623a34a591#dotconf

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/6krjdg388q962rrwb7xh46xkfx91scmx-dotconf-1.4.1
ls -la /nix/store/6krjdg388q962rrwb7xh46xkfx91scmx-dotconf-1.4.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 120m and timed out


Maintainer pings

cc @pSub for testing.

@pSub
Copy link
Member

pSub commented May 8, 2024

This update fixes a potential vulnerability (williamh/dotconf@ced5b7e) and should probably backported to 23.11.

@LeSuisse
Copy link
Contributor

The other change in the 1.4.0 also fixes a buffer overflow (williamh/dotconf@6382711). Looking at the whole diff the bump should be acceptable for a backport.

williamh/dotconf@v1.3...v1.4.1

@LeSuisse LeSuisse added the backport release-23.11 Backport PR automatically label May 13, 2024
@risicle
Copy link
Contributor

risicle commented May 14, 2024

@ofborg build upower

@risicle
Copy link
Contributor

risicle commented May 15, 2024

Funny, that failed for me.

Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upower does not seem to have dotconf in its dep tree?

Built speechd on both Linux aarch64 and x86_64. Everything looks good.

@LeSuisse LeSuisse merged commit f37e89b into NixOS:master May 20, 2024
32 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@r-ryantm r-ryantm deleted the auto-update/dotconf branch May 21, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants