Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ipa: Enable sudo, authorized_keys, and netgroups integration #309612

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benley
Copy link
Member

@benley benley commented May 6, 2024

Description of changes

  • Add sudoWithSssd variant to all-packages.nix
  • nixos/nsswitch: Add sudoers and netgroup nssDatabases options
  • nixos/sssd: Add sudoIntegration option, enable nss netgroup lookups
  • nixos/ipa: Enable sudo and authorized_keys integration when freeipa client is enabled

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@benley benley changed the title nixos/ipa: Enable sudo and authorized_keys integration nixos/ipa: Enable sudo, authorized_keys, and netgroups integration May 10, 2024
@benley
Copy link
Member Author

benley commented May 10, 2024

cc some folks who have touched sssd, nsswitch, and ipa before: @s1341 @nikstur @bjornfor @danc86 @dasJ @outergod @abbradar @arianvp @flokli @aanderse

(sorry for the spam, I'm just looking for a reviewer...)

@bjornfor
Copy link
Contributor

Can you update the NixOS test to exercise the new features?

@benley
Copy link
Member Author

benley commented May 10, 2024

Can you update the NixOS test to exercise the new features?

I will try!

@benley
Copy link
Member Author

benley commented May 16, 2024

fyi it will be a few days before I can get back to this, but I'm going to have a go at adding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants