Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carburetor: init at 4.5.1 #309642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mksafavi
Copy link
Contributor

@mksafavi mksafavi commented May 6, 2024

Description of changes

This PR adds carburetor and it's dependency tractor
Closes #308739

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

I get this error while running it:

Try adding these:

nativeBuildInputs = [
  gobject-introspection # Idk needed or not, try with and without it
  wrapGAppsHook4
];

buildInputs = [
  libadwaita
];

dependencies = [
  # ...
  pygobject3
];

pkgs/by-name/ca/carburetor/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ca/carburetor/package.nix Outdated Show resolved Hide resolved
@mksafavi
Copy link
Contributor Author

mksafavi commented Jun 7, 2024

Thanks for reviewing this.
I made the changes. now both of the apps get built. 👍
running tractor I get this error:

❯ ./result/bin/tractor start

        Please compile the "tractor.gschema.xml" file.
        In GNU/Linux you can copy it from
        "/nix/store/y4fqc4wbn5ycma7pj6qk835dyg7gkzsb-tractor-4.5.1/lib/python3.11/site-packages/tractor"
        to "/nix/store/a2xf8sr12rcps2175198hhy5n2z3ifl1-gsettings-desktop-schemas-46.0/share/gsettings-schemas/gsettings-desktop-schemas-46.0/glib-2.0/schemas" and run:
        "sudo glib-compile-schemas /nix/store/a2xf8sr12rcps2175198hhy5n2z3ifl1-gsettings-desktop-schemas-46.0/share/gsettings-schemas/gsettings-desktop-schemas-46.0/glib-2.0/schemas"

running carburetor I get this:

❯ ./result-2/bin/carburetor
(process:334322): GLib-GIO-ERROR **: 21:10:44.934: Settings schema 'org.tractor' is not installed
fish: Job 1, './result-2/bin/carburetor' terminated by signal SIGTRAP (Trace or breakpoint trap)

@mksafavi mksafavi marked this pull request as ready for review June 7, 2024 17:42
@Aleksanaa
Copy link
Member

It already tells you what should be done ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: carburetor
2 participants