Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-doc: adapt, fix build #309735

Merged
merged 1 commit into from
May 7, 2024
Merged

linux-doc: adapt, fix build #309735

merged 1 commit into from
May 7, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented May 7, 2024 •
edited

Description of changes

  • adopt linux-doc package
  • fix build using docutils patch

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Sigmanificient Sigmanificient changed the title Linux doc: adapt, fix build (wip) linux-doc: adapt, fix build (wip) May 7, 2024
@Sigmanificient Sigmanificient added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 7, 2024
@Sigmanificient Sigmanificient changed the title linux-doc: adapt, fix build (wip) linux-doc: adapt, fix build May 7, 2024
@Sigmanificient Sigmanificient requested a review from drupol May 7, 2024 08:59
drupol
drupol approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@drupol
Copy link
Contributor

drupol commented May 7, 2024

Maybe you'll need to squash into one single commit.

@Sigmanificient
Copy link
Member Author

Sigmanificient commented May 7, 2024 •
edited

ofborg might requests your validation again when it will end evaluation

@drupol drupol merged commit 8b2eeb2 into NixOS:master May 7, 2024
22 of 24 checks passed
@Sigmanificient Sigmanificient deleted the linux-doc branch May 7, 2024 09:50
@Sigmanificient Sigmanificient mentioned this pull request May 9, 2024
Open
@Sigmanificient Sigmanificient added the 0.kind: package adoption Requests for adopting packages that have no maintainers label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
0.kind: package adoption Requests for adopting packages that have no maintainers 0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: kernel 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sigmanificient @drupol