gauche: remove dependency onto gaucheBootstrap #309794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces closure size of the built package by about a third. The only reference to gaucheBootstrap in the built package was in $out/share/gauche-0.98/0.9.13/package-templates/configure, where it is incorrect: anyone using the template shipped with the gauche package would have unintentially used the bootstrap version of gauche instead.
|
Result of 1 package built:
|
leona-ya
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This reduces closure size of the built package by about a third.
The only reference to
gaucheBootstrapin the built package was in $out/share/gauche-0.98/0.9.13/package-templates/configure, where it is incorrect: anyone using the template shipped with the gauche package would have unintentially used the bootstrap version of gauche instead.Alternatives
Simply leaving the interpreter in that file as
/usr/bin/env goshmight also be okay, since presumably it is meant to be executed by a user in a normal environment.We might also consider a use of
remove-references-toto guard against regressions here, but i'm a little undecided on that, as it would possibly break the package's output instead of making it fail to build entirely.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)