Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

litmusctl: init at 1.5.0 #309817

Merged
merged 2 commits into from
May 11, 2024
Merged

litmusctl: init at 1.5.0 #309817

merged 2 commits into from
May 11, 2024

Conversation

Sail0rd
Copy link
Contributor

@Sail0rd Sail0rd commented May 7, 2024

Description of changes

Creation of the litmusctl package, which is a command line tool to manager litmus chaos agent's plane
homepage: https://github.com/litmuschaos/litmusctl

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@Vinetos Vinetos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey !
The MR looks good but one little thing : you should add yourself as a maintainer in a separate commit as described here : https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

When adding yourself as maintainer in the same pull request, make a separate commit with the message maintainers: add <handle>. Add the commit before those making changes to the package or module. See Nixpkgs Maintainers for details.

pkgs/by-name/li/litmusctl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/litmusctl/package.nix Outdated Show resolved Hide resolved
@wegank wegank merged commit 10f84be into NixOS:master May 11, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants