-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
litmusctl: init at 1.5.0 #309817
litmusctl: init at 1.5.0 #309817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey !
The MR looks good but one little thing : you should add yourself as a maintainer in a separate commit as described here : https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions
When adding yourself as maintainer in the same pull request, make a separate commit with the message
maintainers: add <handle>
. Add the commit before those making changes to the package or module. See Nixpkgs Maintainers for details.
Description of changes
Creation of the litmusctl package, which is a command line tool to manager litmus chaos agent's plane
homepage: https://github.com/litmuschaos/litmusctl
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.