-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luaPackages.tree-sitter-norg: init at 0.2.4-1 #309935
Conversation
I also have tree-sitter-haskell working in one of my personal projects 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool !
LGTM
Result of 10 packages built:
|
seems like it needs fixing for darwin (or mark it broken). Hopefully this doesn't get picked up as a vimplugin because it's going to be confusing for users which grammar to install. |
I'll look into fixing it later. I think we need to use the tree-sitter CLI and clang on Darwin.
I haven't added a vimPlugin for it. |
and this is why the approach you take is the best !
sounds not easy. I am fine with merging it as broken for darwin. You do a lot already, maybe let darwin users fix it ? |
I've just pushed a change that ought to fix it for darwin 🤞 |
bf9a3f5
to
290b928
Compare
🤔 no idea how it works on Darwin in the other luarocks-build-treesitter-parser workflow, but not here. |
Description of changes
This will soon be a dependency of neorg.
It is also a POC for packaging tree-sitter parsers with luarocks.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.