tetrio-desktop: run with --in-process-gpu flag #309975
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh I hate all the electron/chromium flags that exist with like no documentation lol, there's probably more applied in the Tetrio code itself that messes with all of this, I wonder if any of those could be the actual root cause of the issue. Should we make sure that this doesn't cause any performance regressions on more systems without this issue? |
|
I'll mark as draft for further testing. Maybe we can put this option behind a flag defaulting to false that has to be overridden? |
|
Sorry, forgot about this. I'll test performance on my system, but if it fixes some issues without performance regression on others, probably worth. What does this flag actually do btw? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #309293
Starting with electron 29, tetrio's webGL will crash when hovering over tooltips on some setups. Upstream has recommended the
--in-process-gpuflag as a workaround.Fixes the crash on my problem machine, with no noticeable performance difference for my unaffected machine.
Tested with both electron 29 and 30.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.