Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caligula: init at 0.4.5 #310023

Merged
merged 2 commits into from
May 11, 2024
Merged

caligula: init at 0.4.5 #310023

merged 2 commits into from
May 11, 2024

Conversation

sodiboo
Copy link
Contributor

@sodiboo sodiboo commented May 8, 2024

Description of changes

Caligula is a user-friendly, lightweight TUI for disk imaging.

https://github.com/ifd3f/caligula

While it works on my machine, which is an x86_64-linux, Caligula also supports macOS. I've copied the required frameworks from the official flake, but it is important to note that i do not own an {x86_64,aarch64}-darwin machine to test on.

cc @ifd3f; you said on mastodon that you were interested in also maintaining the package? can you test that it works on macOS?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ifd3f
Copy link
Contributor

ifd3f commented May 8, 2024

@sodiboo yes, I can add myself as a maintainer in separate PR.

I've tested and it builds and runs on x86_64-darwin and aarch64-darwin, although it has that bug that prevents it from being used on disks in MacOS Sonoma. Wonder if it's possible to mark those versions as broken for now?

@sodiboo
Copy link
Contributor Author

sodiboo commented May 8, 2024

it has that bug that prevents it from being used on disks in MacOS Sonoma

is that a bug upstream? or indirectly introduced by this package, specifically?

Wonder if it's possible to mark those versions as broken for now?

That seems to be possible. From the manual:

If a program ought to work on a certain platform, but doesn’t, the platform should be included in meta.platforms, but marked as broken with e.g. meta.broken = !hostPlatform.isWindows.

I didn't include meta.platforms because i didn't understand it (and my attempts at using it resulted in build failures), but i looked through some other packages now and found out how to actually use it lol. I can add the correct platforms and also mark it as broken on darwin

@sodiboo
Copy link
Contributor Author

sodiboo commented May 8, 2024

is that a bug upstream? or indirectly introduced by this package, specifically?

actually i Looked At Your Issues™ and found it's ifd3f/caligula#105, right?

@ifd3f
Copy link
Contributor

ifd3f commented May 8, 2024

actually i Looked At Your Issues™ and found it's ifd3f/caligula#105, right?

Yes, that's the one.

@wegank wegank merged commit 123e3b2 into NixOS:master May 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants