Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip: --strip-all in libexec, bin, sbin #31025

Closed
wants to merge 1 commit into from

Conversation

lukateras
Copy link
Member

Motivation for this change

#21667 (comment)
#21667 (comment)

I haven't rebuilt system with this patch yet, but @peterhoeg has.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Nov 9, 2017

@nixborg build

@nixborg
Copy link

nixborg commented Nov 9, 2017

Jobset created at https://hydra.mayflower.de/jobset/nixos/pr-31025

@lukateras
Copy link
Member Author

It's very strange for it to fail like that. How does this end up pulling dev paths?

@peterhoeg
Copy link
Member

Any plans to fix the merge conflict so we can get this merged?

@lukateras
Copy link
Member Author

Sure, I can resolve the conflict. Although, are you sure that would make it mergeable? Jobs placed by @globin failed with output is not allowed to refer to path.

@peterhoeg
Copy link
Member

I really want to get the bottom of this so we can get it merged.

@lukateras
Copy link
Member Author

Rebased!

@peterhoeg
Copy link
Member

@globin, any chance nixborg can try this again?

@infinisil
Copy link
Member

@GrahamcOfBorg eval

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Are there any updates on this pull request, please?

@mmahut
Copy link
Member

mmahut commented Jan 24, 2020

Closing due to inactivity.

@mmahut mmahut closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants