-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyfin/jellyfin-web: 10.8.13 -> 10.9.1 #310932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title should be jellyfin: 10.8.13 -> 10.9.0
?
Ah yes, I forgot to change the PR title. Note that the contributing rules do not enforce any convention on the PR title (except backports), this convention is for commit messages. |
Fair enough, thanks for noting that. Does make it easier to search through and filter though :) |
Result of 2 packages failed to build:
|
Result of 3 packages failed to build:
|
Result of 3 packages built:
|
Result of 3 packages built:
|
Thanks for the nixpkgs-reviews @GaetanLepage! Would you be willing to help on the Darwin side of things? I've looked at the ofborg logs, but I couldn't make any sense out of it, and I don't have access to any Darwin machines. |
Here are the relevant logs for darwin:
It looks like it is missing
|
ed78e1f
to
22e4169
Compare
Thanks! I've added the CoreText dependencies, and some others, inspired by the paperless-ngx package, which also depends on node-canvas. Note sure if every dependencies are needed, but I'll need a Darwin user to tell me that. |
Result of 2 packages built:
|
Result of 3 packages built:
|
Result of 3 packages failed to build:
|
Result of 3 packages built:
|
It now builds fine on
|
Welp, I'm definitely not familiar enough with the Darwin specifics to debug that… |
overrideSDK stdenv {
darwinMinVersion = "10.15";
darwinSdkVersion = "11.0";
} |
22e4169
to
67c123c
Compare
Thanks a lot @reckenrode! I've attempted to use your suggestion. Let's see if I understood it correctly, and if it works. |
Result of 3 packages built:
|
Result of 3 packages built:
|
10.9.1 has already been released, could this PR be updated for that? |
67c123c
to
a937d57
Compare
@pyrox0 done |
Result of 3 packages built:
|
Successfully created backport PR for |
Description of changes
This release fixes some security vulnerabilities (see GitHub changelog).
Tested using the NixOS test, and a bit inside a clean VM, everything seems to work fine.
They have removed the DLNA feature from the core jellyfin, in favor of a DLNA plugin. Not sure if we should consider this a breaking change.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)cc @nyanloutre @purcell @jojosch
Add a 👍 reaction to pull requests you find important.