Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpPackages.redis: rev 4a37e4 -> 3.1.4 #31158

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Nov 2, 2017

Motivation for this change

The redis extension for PHP7 has been officially released for a while now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Since the tests require a live redis server, I tested the extension using nix-shell default.nix -A php70Packages.redis and nix-shell default.nix -A php71Packages.redis and running the test manually in a checkout of the source repository instead of enabling doCheck.

Like #31153, I'm testing on a multi-user setup on Ubuntu Xenial. nox-review and sandboxing do not appear to be working on my setup currently.

@Mic92
Copy link
Member

Mic92 commented Nov 3, 2017

Thanks!

@Mic92
Copy link
Member

Mic92 commented Nov 3, 2017

Does this need a backport?

@jbboehr
Copy link
Contributor Author

jbboehr commented Nov 3, 2017

@Mic92 Assuming you are asking me, I'm not sure, although it seems wise to use a tagged release when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants