netbox-reorder-rack: init at 1.0.0 #311657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Sigmanificient
suggested changes
May 14, 2024
pkgs/development/python-modules/netbox-reorder-rack/default.nix
Outdated
Show resolved
Hide resolved
minijackson
force-pushed
the
init-netbox-reorder-rack
branch
from
bc964dd
to
aa6a1f8
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4032 |
pkgs/development/python-modules/netbox-reorder-rack/default.nix
Outdated
Show resolved
Hide resolved
| export PYTHONPATH=${netbox}/opt/netbox/netbox:$PYTHONPATH | ||
| ''; | ||
|
|
||
| dontUsePythonImportsCheck = python.pythonVersion != netbox.pythonVersion; |
There was a problem hiding this comment.
Suggested change
| dontUsePythonImportsCheck = python.pythonVersion != netbox.pythonVersion; | |
| dontUsePythonImportsCheck = python.pythonVersion != netbox.python.pythonVersion; |
Why not build netbox with the correct python version?
There was a problem hiding this comment.
NetBox itself is a python "application", so it's only built for one version of Python, in my opinion it doesn't make much sense to build it multiple times.
used in order to figure out if we can test a given NetBox plugin
not 1.1.0 yet because that version is only compatible with NetBox>=4.0.0
minijackson
force-pushed
the
init-netbox-reorder-rack
branch
from
aa6a1f8
to
ce84d1e
Compare
13 tasks
SuperSandro2000
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A NetBox plugin for reordering racks using click and drop: https://github.com/minitriga/netbox-reorder-rack
Not packaged using v1.1.0 yet, because that version is only compatible with NetBox>=4.0.0.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Tested by running NetBox with that plugin enabled inside a clean VM.
@RaitoBezarius & @n0emis might be interested in this.
Add a 👍 reaction to pull requests you find important.