New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: 1.20.0 -> 1.21.0 #31175
rust: 1.20.0 -> 1.21.0 #31175
Conversation
@GrahamcOfBorg rust.rustc |
I still have to test #31125 on linux, but we should probably merge those 2 at the same time. |
cc @Mic92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For system: x86_64-linux
/nix/store/3mnmsm8llyr6ggzpfdvdn5nl47q7sdq3-rustc-1.21.0/lib/rustlib/uninstall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4sp0sc2wxas7213x59smrwhliqmhc5yk-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-rustc-1.21.0.drv-0 in /nix/store/3mnmsm8llyr6ggzpfdvdn5nl47q7sdq3-rustc-1.21.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/yhrxg95axmba9npkyrv129f4kx22hv3g-rustc-1.21.0-man
gzipping man pages under /nix/store/yhrxg95axmba9npkyrv129f4kx22hv3g-rustc-1.21.0-man/share/man/
patching script interpreter paths in /nix/store/yhrxg95axmba9npkyrv129f4kx22hv3g-rustc-1.21.0-man
checking for references to /tmp/nix-build-rustc-1.21.0.drv-0 in /nix/store/yhrxg95axmba9npkyrv129f4kx22hv3g-rustc-1.21.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/81yqhgzv2m6756c12pblhv2jzzx0a9ab-rustc-1.21.0-doc
patching script interpreter paths in /nix/store/81yqhgzv2m6756c12pblhv2jzzx0a9ab-rustc-1.21.0-doc
checking for references to /tmp/nix-build-rustc-1.21.0.drv-0 in /nix/store/81yqhgzv2m6756c12pblhv2jzzx0a9ab-rustc-1.21.0-doc...
/nix/store/3mnmsm8llyr6ggzpfdvdn5nl47q7sdq3-rustc-1.21.0
Last time there was a problem with compiling firefox, is this resolved now? |
I currently try to build firefox with this pr. |
Firefox fails due to these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For system: x86_64-darwin
Building stage0 compiler artifacts (x86_64-apple-darwin -> x86_64-apple-darwin)
thread 'main' panicked at 'failed to execute command: "/nix/store/h8q71ig8b8i83xbza1fasq0p2ci030cq-rustc-bootstrap-1.20.0/bin/cargo" "build" "-j" "2" "--target" "x86_64-apple-darwin" "--release" "--frozen" "--features" " jemalloc llvm" "--manifest-path" "/private/tmp/nix-build-rustc-1.21.0.drv-0/rustc-1.21.0-src/src/rustc/Cargo.toml" "--message-format" "json"
error: No such file or directory (os error 2)', src/bootstrap/compile.rs:815:18
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failed to run: /private/tmp/nix-build-rustc-1.21.0.drv-0/rustc-1.21.0-src/build/bootstrap/debug/bootstrap build
Build completed unsuccessfully in 1:32:26
make: *** [Makefile:24: all] Error 1
builder for '/nix/store/px4i6isbjgqnnaqyww125f4y165l8cwf-rustc-1.21.0.drv' failed with exit code 2
error: build of '/nix/store/px4i6isbjgqnnaqyww125f4y165l8cwf-rustc-1.21.0.drv' on 'ssh://mac1' failed: builder for '/nix/store/px4i6isbjgqnnaqyww125f4y165l8cwf-rustc-1.21.0.drv' failed with exit code 2
error: build of '/nix/store/px4i6isbjgqnnaqyww125f4y165l8cwf-rustc-1.21.0.drv' failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For system: x86_64-darwin
cp: -r not specified; omitting directory 'target/release'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/incremental'
cp: -r not specified; omitting directory 'target/release/native'
post-installation fixup
stripping (with flags -S) in /nix/store/kdk4fyrccdny7a7iyw96ryhrnxplxc3q-cargo-0.22.0/bin
patching script interpreter paths in /nix/store/kdk4fyrccdny7a7iyw96ryhrnxplxc3q-cargo-0.22.0
I tried backport some of the fixes from firefox 57 but it's getting kind of messy, perhaps we should start versioning rust like we do with other compilers? |
Do you mean for 17.09? We should backport all the browser updates, and not
fret about individual FF patches.
…On Sun 5. Nov 2017 at 23:17, Daiderd Jordan ***@***.***> wrote:
I tried backport some of the fixes from firefox 57 but it's getting kind
of messy, perhaps we should start version rust like we do with other
compilers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31175 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYRM6tGme0NbtmTty7wDLOeEoG21G-snks5szjP0gaJpZM4QQsv8>
.
|
No, FF 57 is not released yet and the current version doesn't build with rust 1.21. |
the cyborg can talk😳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shrinking /nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0/lib/firefox-57.0/libmozsandbox.so
shrinking /nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0/lib/firefox-57.0/libmozavcodec.so
stripping (with flags -S) in /nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0/lib /nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0/bin
patching script interpreter paths in /nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0
/nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0/lib/firefox-57.0/run-mozilla.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-firefox-unwrapped-57.0.drv-0 in /nix/store/4q8x93zd34ivijg8v70pwkm5k2jsahvy-firefox-unwrapped-57.0...
running install tests
Mozilla Firefox 57.0
Motivation for this change
Rust 1.21.0 has been released
Things done
nix-shell -p nox --run "nox-review wip"
./result/bin/
)