Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] git: 2.44.0 -> 2.44.1 #311801

Merged
merged 1 commit into from
May 15, 2024
Merged

[staging] git: 2.44.0 -> 2.44.1 #311801

merged 1 commit into from
May 15, 2024

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented May 15, 2024

Description of changes

CVE-2024-32002, CVE-2024-32004, CVE-2024-32465, CVE-2024-32020, CVE-2024-32021
https://github.blog/2024-05-14-securing-git-addressing-5-new-vulnerabilities/

Backport to 23.11: #311817

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

CVE-2024-32002, CVE-2024-32004, CVE-2024-32465, CVE-2024-32020,
CVE-2024-32021
@edef1c
Copy link
Member Author

edef1c commented May 15, 2024

Having reviewed the commits included, I feel fairly confident this will build fine, and would rather get this into Hydra quickly (given the RCE involved), so I will likely merge this sooner rather than later.

Copy link
Contributor

@kashw2 kashw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, Thanks!

@vcunat vcunat self-assigned this May 15, 2024
@vcunat vcunat changed the base branch from staging to staging-next May 15, 2024 05:58
@vcunat vcunat merged commit 413cfaa into NixOS:staging-next May 15, 2024
39 of 44 checks passed
@vcunat
Copy link
Member

vcunat commented May 15, 2024

Not RCE on Linux if I read it right, but I expedited it anyway. At this moment it most likely won't waste that much of rebuild work, and *-darwin are significant for us.

@edef1c edef1c deleted the git-2.44.1 branch May 15, 2024 12:37
@vcunat vcunat mentioned this pull request May 17, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants