nixos/rosenpass: move preStart into script to workaround systemd bug #311986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a systemd bug, using both ExecStartPre and ExecStart will fill up the systemd credentials directory, which leads to rosenpass failing to start. This will be fixed in systemd v256, see systemd/systemd#31202 Related issue: NixOS#258371
|
Could you please provide more context? Which bug? systemd/systemd#24734 (comment)? Is it what @wahjava mentioned here #254813 (comment)? If so, then I'd like to defer to @wahjava and get their opinion. If it's a workaround until systemd 256, maybe add a comment to move it back once NixOS is on systemd 256 or newer? |
|
Oh sorry, i mentioned the issue you linked in the commit message, but not in the pull request description. |
|
@ofborg test rosenpass |
lorenzleutgeb
approved these changes
May 15, 2024
lorenzleutgeb
added
needs_merger
12.approvals: 1
12.approved-by: package-maintainer
and removed
12.approved-by: package-maintainer
labels
|
Looks good to me. This is exactly what I'm doing as a workaround until fixed systemd makes it into the tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rosenpass currently fails to start because of a bug in systemd (see #258371 and systemd/systemd#31202), which is fixed in systemd v256.
This PR makes rosenpass work by moving the preStart command also into script.
This is just a workaround to get rosenpass to work until we have systemd v256. I'm not sure how much of a difference it makes, but we should probably revert this once we are on systemd v256.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@lorenzleutgeb you wrote the rosenpass module, could you review this change?
Add a 馃憤 reaction to pull requests you find important.