Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: 29.3.3 -> 29.4.0, 30.0.3 -> 30.0.6 #312376

Merged
merged 4 commits into from
May 20, 2024

Conversation

yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented May 17, 2024

Will need to cherry-pick the updates to stable myself.

Description of changes

Electron 29

Electron 30

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@yayayayaka yayayayaka added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels May 17, 2024
@yayayayaka yayayayaka added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 17, 2024
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 312376 run on x86_64-linux 1

1 package marked as broken and skipped:
  • itch
57 packages built:
  • affine
  • antares
  • bilibili
  • bitwarden-directory-connector
  • breitbandmessung
  • bruno
  • camunda-modeler
  • drawio
  • drawio-headless
  • electron (electron_29)
  • electron-bin (electron_29-bin)
  • electron_30
  • electron_30-bin
  • element-desktop
  • element-desktop-wayland
  • fcast-receiver
  • freetube
  • headset
  • heroic
  • heroic-unwrapped
  • jitsi-meet-electron
  • koodo-reader
  • kuro
  • nix-tour
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • passky-desktop
  • podman-desktop
  • pritunl-client
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • sharedown
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • youtube-music
  • ytdownloader

2024-05-20_09-20

@yayayayaka
Copy link
Member Author

Thanks!

@yayayayaka yayayayaka merged commit 88785de into NixOS:master May 20, 2024
34 of 36 checks passed
@yayayayaka yayayayaka deleted the electron-updates branch May 20, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants