Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ks: init at 0.0.4 #312401

Merged
merged 1 commit into from
May 22, 2024
Merged

ks: init at 0.0.4 #312401

merged 1 commit into from
May 22, 2024

Conversation

ivankovnatsky
Copy link
Contributor

@ivankovnatsky ivankovnatsky commented May 17, 2024

Description of changes

Adds new OS specific package for Darwin only. Command-line secrets manager powered by macOS keychains.
Basically a wrapper around builtin Darwin security CLI command.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

@infinisil interesting edge case for by-name check

@kirillrdy
Copy link
Member

@ivankovnatsky i think your original approach was pretty valid, maybe wait for @infinisil to comment

pkgs/os-specific/darwin/ks/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/darwin/ks/default.nix Outdated Show resolved Hide resolved
@kirillrdy
Copy link
Member

@ivankovnatsky can you swash commits

@ivankovnatsky
Copy link
Contributor Author

ivankovnatsky commented May 17, 2024

@ivankovnatsky can you swash commits

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants