Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmcl: 3.5.5 -> 3.5.8 #312474

Closed
wants to merge 5 commits into from
Closed

hmcl: 3.5.5 -> 3.5.8 #312474

wants to merge 5 commits into from

Conversation

Bot-wxt1221
Copy link
Contributor

@Bot-wxt1221 Bot-wxt1221 commented May 17, 2024

Description of changes

hmcl: 3.5.5 -> 3.5.8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@getchoo
Copy link
Member

getchoo commented May 20, 2024

Result of nixpkgs-review pr 312474 run on aarch64-linux 1

1 package built:
  • hmcl

@pbsds
Copy link
Contributor

pbsds commented May 21, 2024

please rewrite the git history to squash the updates into one commit and squash the maintainer addition to an other commit preceeding the bump. Please follor the commit schema of maintainers: add xyz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants