[23.11] nixos/snapper: Add peristentTimer option to config

[mrkline]

Defaults to false, but allows users to enable it for machines that aren't on persistently (e.g., laptops, home PCs).

Backport of 2c55e03 (#306909) but using lib.mdDoc to be consistent with the rest of the options on this branch.

[mrkline]

@tomberek if you've got the time to take a look over the backport as well, much appreciated!

[jian-lin]

Thanks for your contribution.

Here is some doc for manual backport: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes. Could you make some changes such as PR title and git cherry-pick -x according to that?

using lib.mdDoc to be consistent with the rest of the options on this branch

This is indeed an disadvantage of auto backport, which I think is acceptable. If you want an auto backport, I can help with that.

[mrkline]

AIUI cherry-pick -x adds a line referencing the commit it's coming from - I've done that (and referenced the PR).

And it's not a cherry-pick (neither manual nor auto-backported), as the commit message notes - I've changed it to match the rest of the module's args in 23.11

[jian-lin]

AIUI cherry-pick -x adds a line referencing the commit it's coming from - I've done that (and referenced the PR).

I see you link that PR in the description.

What I ask is that you also reference the backported commit hash ff0f4540c088913db38d9a5006b4a85e768c9ae5 in the commit message like what git cherry-pick -x gives you.

as the commit message notes - I've changed it to match the rest of the module's args in 23.11

I see you add lib.mkDoc here.

I suggest an auto-backport because the addition of lib.mkDoc is, in my opinion, only cosmetic and the auto-backport references to both the PR and the commit hash properly.

And it's not a cherry-pick (neither manual nor auto-backported)

Usually, a manual backport indicates modifying the cherry-picked commit, either in place or in a new commit.

Could you make some changes such as PR title

Not sure if you missed this suggestion or you intend to not do this. Anyway, I have changed it because I see no harm of it. Hope you do not mind.

[mrkline]

What I ask is that you also reference the backported commit hash

The PR description contains that as well; I assumed that it would be used as the commit message when the PR is merged.

I suggest an auto-backport

I'm not a maintainer (yet!), so I don't think I have the powers to do so.

I force-pushed a commit generated from cherry-pick -x, referencing the previous commit and PR. I hope that addresses your feedback - apologies for any misunderstanding!

[jian-lin]

nit: Should it be Persistent? If so, this (and the one in the borgbackup module) can be fixed in a future PR.

[mrkline]

Addressed with #314099

[jian-lin]

The PR description contains that as well; I assumed that it would be used as the commit message when the PR is merged.

It is not the case for two of three merge methods on GitHub.

I'm not a maintainer (yet!), so I don't think I have the powers to do so.

I know and that's why I say I can help with that (adding the needed tag). I should have stated that more clear.

Again, thanks.