Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchurl: add passthru #31271

Merged
merged 1 commit into from
Nov 6, 2017
Merged

fetchurl: add passthru #31271

merged 1 commit into from
Nov 6, 2017

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 5, 2017

so that we could add e.g. the version attribute.

Motivation for this change

There have been discussions in the past about adding a version parameter to stdenv.mkDerivation. In my opinion, version is an attribute of the source, and therefore I propose having the possibility to add it to the source, using passthru.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

so that we could add e.g. the `version` attribute.
@FRidh FRidh merged commit 13cc4f5 into NixOS:master Nov 6, 2017
@FRidh FRidh deleted the fetchurl branch November 6, 2017 19:41
@FRidh FRidh mentioned this pull request Nov 7, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants