Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bend: init at 0.2.9 #312972

Merged
merged 2 commits into from
May 20, 2024
Merged

bend: init at 0.2.9 #312972

merged 2 commits into from
May 20, 2024

Conversation

k3yss
Copy link
Contributor

@k3yss k3yss commented May 19, 2024 •
edited
Loading

Description of changes

Add support for Bend, a massively parallel, high-level programming language from https://higherorderco.com .
resolves #312527

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 312972 run on x86_64-linux 1

1 package built:
  • bend

RaghavSood
RaghavSood reviewed May 20, 2024
View reviewed changes
Copy link
Member

@RaghavSood RaghavSood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run:

nix shell nixpkgs/master#nixfmt-rfc-style -c nixfmt pkgs/by-name/be/bend/package.nix

Your commits should also be limited to:

maintainers: add k3yss
bend: init at 0.2.9

Please squash everything else

pkgs/by-name/be/bend/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/be/bend/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/be/bend/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/be/bend/package.nix Outdated Show resolved Hide resolved
@RaghavSood
Copy link
Member

Also appears that we do already package HVM, so this should take #313053 into account once it is merged.

@k3yss
Copy link
Contributor Author

k3yss commented May 20, 2024

Also appears that we do already package HVM, so this should take #313053 into account once it is merged.

I will make another PR once the version is upgraded.

jeremyschlatter
jeremyschlatter reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@jeremyschlatter jeremyschlatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on aarch64-darwin, looks good to me.

Bit of a nit, but probably better to reorder the commits so maintainers: add k3yss comes first. As it is lib.maintainers.k3yss not defined when it is first used in bend: init at 0.2.9.

jeremyschlatter
jeremyschlatter approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jeremyschlatter jeremyschlatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyschlatter
Copy link
Contributor

Could you add Resolves #312527 to the PR description? That will cause issue #312527 to automatically close when this is merged.

@RaghavSood
Copy link
Member

#313053 has been merged as well

@k3yss
Copy link
Contributor Author

k3yss commented May 20, 2024

It should be good to go!

@Misterio77
Copy link
Member

Result of nixpkgs-review pr 312972 run on x86_64-linux 1

1 package built:
  • bend

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 312972 run on aarch64-darwin 1

1 package built:
  • bend

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 312972 run on x86_64-linux 1

1 package built:
  • bend

@RaghavSood RaghavSood merged commit 30022e1 into NixOS:master May 20, 2024
24 of 25 checks passed
@RaghavSood
Copy link
Member

I'm able to successfully evaluate all_tree.bend from #312527, LGTM.

@k3yss k3yss deleted the os/keys/bend-lang branch May 20, 2024 17:08
@k3yss k3yss mentioned this pull request May 25, 2024
Open
@k3yss
Copy link
Contributor Author

k3yss commented May 27, 2024

Result of nixpkgs-review pr 312972 run on x86_64-linux 1

1 package built:
  • bend

@developedby developedby mentioned this pull request Jun 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

@Misterio77 Misterio77 Misterio77 approved these changes

@jeremyschlatter jeremyschlatter Awaiting requested review from jeremyschlatter

Assignees
No one assigned
Labels
8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: bend
5 participants
@k3yss @RaghavSood @jeremyschlatter @Misterio77 @NixOSInfra